Automattic / Automattic/simplenote-electron

In a dark theme, the menu bar, title bar and pop-up menus are displayed with a white background

Open
#1,799 3 comments 2 reactions 0 assignees View on GitHub
[OS] windows bug
Dominant language
TypeScript
Stars
5.3k
Forks
588
Avg merge
9h 45m
Merged PRs (30d)
4

Description

### Expected
When the dark theme is on, the menu bar, title bar and pop-up menus when clicking on File, Edit, etc. on the menu bar are displayed with a dark background.

### Observed
When the dark theme is on, the menu bar, title bar and pop-up menus when clicking on File, Edit, etc. on the menu bar are displayed with a white background.

### Reproduced
1. Click on File in the menu bar
2. Click on Preferences...
3. Click Display
4. Go to Theme
5. Click on Dark
6. Click on File in the menu bar

![image](https://user-images.githubusercontent.com/19418601/71577108-e67bf100-2b03-11ea-8087-d2c7d2ec9fd8.png)

Make|Model|OS Version|App Version
-|-|-|-
SYSTEM_MAKE|SYSTEM_MODEL|Windows 10 v. 1909|1.12.0

This is due to problem https://github.com/Automattic/simplenote-electron/issues/1036, but I'm also talking about a pop-up window, and it has been a year already, and in applications such as Spotify, Discord, GitHub Desktop, Visual Studio Code, the menu bar, title bar and pop-up windows are dark.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue on Windows 10 through Preferences > Display > Theme, then inspect the Electron menu, title-bar, and pop-up window theme handling. Done means the menu bar, title bar, and File/Edit pop-up menus use dark backgrounds when the Dark theme is selected, without regressing the light theme.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.