Automattic / Automattic/simplenote-android
Dark theme: Dark at night only doesn't change note list theme when blank editor screen is open
- Dominant language
- Java
- Stars
- 1.9k
- Forks
- 318
- Avg merge
- 15h 23m
- Merged PRs (30d)
- 5
Description
### Expected
When the `Dark at night only` theme is selected, I expect the theme to change throughout the app at 6am and 10pm regardless of what screen is open.
### Observed
If I have the note editor open to a new, blank note when the app switches between light/dark themes, the note editor changes theme but the note list does not (unless the app is closed and reopened).
### Reproduced
1. In Settings > Theme in the app, set the theme to `Dark at night only`.
2. In your device settings, set the time to 5:59am.
3. Go back to the app and confirm that it shows a dark theme.
4. Create a new note in the app but don't add any content.
5. When the time hits 6:00am, confirm the note editor switches to the light theme.
6. Close the editor to go back to the note list. Note that it still shows the dark theme even though it should have switched to light theme.
7. Close the app and reopen it, and confirm that the light theme is showing throughout the app.
Make|Model|Android Version|App Version
-|-|-|-
Motorola|e5 play|8.1.0|2.1-rc-1
Contributor guide
Research direction
Start in the Android app with Settings > Theme and reproduce the transition using a blank new note at 5:59am and 6:00am. Trace how the theme change reaches the note editor and note list, then verify that closing the blank editor shows the updated theme without restarting the app.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100