Automattic / Automattic/simplenote-android

History should be restored only after `RESTORE` tap

Open
#1,347 0 comments 0 reactions 0 assignees View on GitHub
[feature] history [Type] Bug
Dominant language
Java
Stars
1.9k
Forks
318
Avg merge
15h 23m
Merged PRs (30d)
5

Description

### Expected
Once the user has moved the revision slider, tapping/clicking outside the history popover should be similar to `CANCEL`. This is so on iOS, macOS and Electron.

p1615981120005800-slack-C01KRRK0MLJ

### Observed
When the history slider is moved, the note content changes, but the user is still free to tap `CANCEL` or `RESTORE`. Tapping outside the history popover will restore the selected revision:

https://user-images.githubusercontent.com/73365754/111460574-cf371c80-8724-11eb-8812-4913aa80c73c.mp4

### Reproduced
1. Have a note with history available
2. Open revision slider
3. Move the slider so that you can see the difference in note content
4. Tap outside the popover to close it ~> the revision selected with slider will be used.

### Device
Device Make: Samsung
Device Model: A31
Android Version: 10
Simplenote Version: 2.18-rc-1

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the history popover flow on Android with a note that has revisions, then trace the slider, outside-dismissal, CANCEL, and RESTORE handling. Verify that tapping outside leaves the note as CANCEL would and that only RESTORE commits the selected revision.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.