Automattic / Automattic/pym-shortcode

Use Gutenberg's native `anchor` support for setting the pym parent element ID

Open
#36 2 comments 0 reactions 1 assignee Claimed by @claudiulodro View on GitHub
gutenberg
Dominant language
PHP
Stars
15
Forks
8
PR merge metrics
No merged PRs in 30d

Description

We didn't do this in the initial implementation of Gutenberg blocks in #34 because, at the time, it appeared as if there was no way to use Gutenberg's `anchor` property with a block that was dynamically rendered.

For more history, see the following comments:

- https://github.com/INN/pym-shortcode/pull/34#issuecomment-417355256
- https://github.com/WordPress/gutenberg/issues/6356#issuecomment-417176119
- https://github.com/WordPress/gutenberg/pull/8154/files, the current version of which is https://wordpress.org/gutenberg/handbook/block-api/#supports-optional

Elements of this ticket:

- [ ] remove the shim introduced in #34
- [ ] add a `supports` declaration for `anchor`
- [ ] add the `anchor` output to the pym_shortcode function.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.