Automattic / Automattic/pocket-casts-ios

"Include Starred" button when managing downloads is broken/confusing

Open
#84 0 comments 0 reactions 0 assignees View on GitHub
[Type] Bug Downloads
Dominant language
Swift
Stars
1.8k
Forks
197
Avg merge
17h 20m
Merged PRs (30d)
103

Description

## Actual Behavior
The behavior of the bytes value seems off when using the starred toggle. I'm not sure what it is doing, but I don't think it is what it should be doing because it makes no sense to me.

## Expected Behavior

The "size" by the "Include Starred" toggle should represent how much toggling that value will change the total

### Steps to reproduce the behavior

Toggle the `Include Starred` setting from the screen for deleting your downloads (Downloaded Files -> overflow menu -> Clean Up)

### Video

https://user-images.githubusercontent.com/4656348/179597304-735fc7eb-40ad-4704-bccc-35980aeec02c.mov

##### Tested on IPhone Xr, iOS 15.5, Pocket Casts 7.20 (880)

Contributor guide

Open the contributing guide

Research direction

Reproduce this from Downloaded Files, using the overflow menu and then Clean Up, and toggle Include Starred while watching the size value. Trace the calculation behind that toggle and compare the displayed size with the change it makes to the total. Done means the size by the toggle represents how much enabling or disabling Include Starred changes the total.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.