Automattic / Automattic/pocket-casts-ios

Tooling: use upstream danger-ruby-swiftformat version

Open
#59 0 comments 0 reactions 0 assignees View on GitHub
[Type] Enhancement [Type] Tooling
Dominant language
Swift
Stars
1.8k
Forks
197
Avg merge
17h 20m
Merged PRs (30d)
103

Description

We use [a fork](https://github.com/shiftyjelly/danger-ruby-swiftformat) of the [original `danger-ruby-swiftformat` plugin](https://github.com/garriguv/danger-ruby-swiftformat/).

Judging by the commit history in the fork we use, I'd say the reason was because the upstream version didn't support a SwiftFormat change. As far as I can see, that change [has now been supported](https://github.com/garriguv/danger-ruby-swiftformat/pull/33).

However, there's no urgent reason to switch, really, other than running on "official" tools.

Contributor guide

Open the contributing guide

Research direction

Inspect the project's dependency and tooling configuration to find where the shiftyjelly danger-ruby-swiftformat fork is selected. Compare that declaration with the upstream danger-ruby-swiftformat repository and PR #33, then verify that the project uses the upstream plugin and its SwiftFormat support remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, swift
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.