Automattic / Automattic/pocket-casts-ios
Adding/removing Siri shortcuts from the Filter shortcut view can cause crash
- Dominant language
- Swift
- Stars
- 1.8k
- Forks
- 198
- Avg merge
- 17h 20m
- Merged PRs (30d)
- 103
Description
### Description
When adding and removing items from Filter's Siri shortcuts menu the app can crash with an index out of bounds error
### Steps to reproduce the behavior
1. On a real device
2. Launch the app
3. Go to Profile > Settings Cog
4. Tap Siri Shortcuts
5. Tap on Shortcut to a specific filter
6. Tap on any filter
7. Tap any of the shortcuts to add it
8. Tap it again to and select the remove item
9. Tap it again and tap done
10. The app can crash
##### Tested on [device], iOS [version], Pocket Casts [version]
iPhone 8 Plus, iOS 16
Contributor guide
Research direction
Reproduce the crash on a real iPhone by following the Profile > Settings > Siri Shortcuts > Shortcut to a specific filter sequence, especially after adding, removing, and completing a shortcut. Trace the index out of bounds failure in the Siri Shortcuts filter view; done means the sequence completes without a crash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100