Automattic / Automattic/pocket-casts-android
Broken sounding voice with trim silence turned on
- Dominant language
- Kotlin
- Stars
- 2.8k
- Forks
- 308
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 187
Description
An episode of a private feed plays in faster speed when only trim silence is turned on.
Russell noted:
> In looking into this it does seem like our RMS calculations aren't really suited for figuring out the relative volume of a speaker. So say your show is mixed super quiet and you turn your phone volume way up our calculations are still calculating the RMS regardless of what the playback volume is. For this podcast our setting of 30 cuts at least half of what this person is saying off. Even a setting of 10 doesn't work in this case.
>
> In order to fix this we'd have to change over to calculating relative volume instead of absolute
Contributor guide
Research direction
Start by reproducing the private-feed episode with only trim silence enabled, then inspect the RMS calculations used by the trimming path. The issue indicates that absolute volume is cutting speech from quiet mixes; done should mean quiet speakers are not disproportionately removed and playback no longer sounds faster.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100