Automattic / Automattic/pocket-casts-android

Refactor positionMs and durationMs to be long instead of int

Open
#70 0 comments 0 reactions 0 assignees View on GitHub
[Type] Tech Debt Migrated
Dominant language
Kotlin
Stars
2.8k
Forks
308
Avg merge
1d 10h
Merged PRs (30d)
187

Description

We would save a lot of casting if we switched `positionMs` and `durationMs` to be `long` instead of `int`. Exoplayer uses long and we use int. It might overflow at some point as well which might be why Exoplayer uses long.

Contributor guide

Open the contributing guide

Research direction

No file, test, or entry point is named. Start by locating the declarations and call sites for positionMs and durationMs in the Kotlin Android codebase, then trace the casts and ExoPlayer boundaries. Done means both values use long consistently without the current casts or int overflow risk, with the project’s existing checks still passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.