Automattic / Automattic/pocket-casts-android

Adding new themes

Open
#614 0 comments 2 reactions 0 assignees View on GitHub
[Type] Feature
Dominant language
Kotlin
Stars
2.8k
Forks
308
Avg merge
1d 13h
Merged PRs (30d)
143

Description

### What problem does this address?

Currently, it is not possible to contribute new themes, since the themes are loaded from a private document. I would like to contribute a [Nord](https://nordtheme.com), but that's not possible, since I can't view or edit the document.

Example screenshots of the Nord theme

![Screenshot_1669407257](https://user-images.githubusercontent.com/63370021/204052282-0706a113-7be3-4979-8e55-03e86a175df7.png)
![Screenshot_1669407267](https://user-images.githubusercontent.com/63370021/204052285-2759c7e4-2d16-4eeb-aac5-2ff0655c3d46.png)
![Screenshot_1669407277](https://user-images.githubusercontent.com/63370021/204052287-485ef265-0b79-46df-8746-3729c8542209.png)
![Screenshot_1669407283](https://user-images.githubusercontent.com/63370021/204052288-c6597ebb-04ad-4f1b-8a7a-ec180aa7277f.png)
![Screenshot_1669407286](https://user-images.githubusercontent.com/63370021/204052292-fa78ab72-dcb9-45b8-a7fc-1c51f5266f6d.png)
![Screenshot_1669407289](https://user-images.githubusercontent.com/63370021/204052299-dc95b739-8bdc-40e2-90c0-e435c3d49344.png)
![Screenshot_1669407294](https://user-images.githubusercontent.com/63370021/204052300-d5340c46-0df0-494a-ba7b-54262d023081.png)
!

### What is your proposed solution?

I feel like there are three possible solutions to this problem.

1. I could overwrite and contribute the generated theme files, resulting in a mess and a denied pull request.
2. Contribute a set of colors, hoping someone with write access to the document will create the theme.
3. If the document could be publicly viewed, it would be possible to create the needed rows, and a team member would only need to copy them over.

If think it would be really need for the community to create themes and contribute them, so I think solution 3 would be the best one, with the least amount of work required.

### Did you search for existing feature suggestions?

- [X] I have searched for existing feature suggestions.

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by tracing how themes are loaded from the private document and how generated theme files are produced; done would require a documented, maintainable contribution path that lets community members add themes.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
design, mobile-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.