Automattic / Automattic/pocket-casts-android
Tracks event for the filter list has incorrect filter count after deleting a filter
- Dominant language
- Kotlin
- Stars
- 2.8k
- Forks
- 308
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 143
Description
When deleting a filter, the tracks event for the Filters screen (`filter_list_shown`) that is immediately shown does not accurately reflect the deletion of the filter. Specifically, the count is what you would expect if you had not deleted a filter.
1. Create a new filter
2. Return to Filters screen
3. Observe the filter count logged in Tracks: `🔵 Tracked: filter_list_shown, Properties: {"filter_count":[N],..`
4. Tap on the new filter
5. Delete the new filter using the overflow menu
6. 🔴 Observe that when you are returned to the Filters screen the same filter count is logged even though there is now one less filter.
h/t to @ashiagr for [identifying this](https://github.com/Automattic/pocket-casts-android/pull/349#issuecomment-1262086755).
Contributor guide
Research direction
Reproduce the six steps in the issue and trace the Filters screen return flow and its Tracks `filter_list_shown` event after deletion. Done means the event logged on returning to the Filters screen reports a filter count one lower than before deletion; no file or test path is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- analytics, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100