Automattic / Automattic/pocket-casts-android

Check if we still need this Proguard rule

Open
#125 0 comments 0 reactions 0 assignees View on GitHub
[Type] Tech Debt Migrated
Dominant language
Kotlin
Stars
2.8k
Forks
308
Avg merge
1d 13h
Merged PRs (30d)
143

Description

```
# Without this the playback notification doesn't show up on fresh launch
# https://github.com/shiftyjelly/pocketcasts-android/issues/1656
-keep class au.com.shiftyjelly.pocketcasts.core.player.** { *; }
```
This has now been moved to the package: au.com.shiftyjelly.pocketcasts.repositories.playback

**Below is issue 1656**

Notifications - Media control notification doesn't appear in certain conditions

**Steps to Replicate**

1. Clear app storage.
2. Start the app.
3. Tap on a podcast.
4. Choose an episode and tap on the playback icon.
5. Verify that the Pocket Cast icon is shown on the status bar.
6. Next, pull the notification drawer and check if the media controls are visible.
7. Then, lock the screen by pressing the power button.
8. Verify that the media control is also visible.

**Observations**
- No Pocket Cast icon on the status bar.
- Media Control notification is not seen from the notification drawer nor the lockscreen.
- When I force-stop the app, restarted, and did the same steps again then the status bar icon and media controls are seen.

Contributor guide

Open the contributing guide

Research direction

Locate the Proguard configuration containing the keep rule for au.com.shiftyjelly.pocketcasts.core.player.** and compare it with the moved au.com.shiftyjelly.pocketcasts.repositories.playback package. Reproduce the issue 1656 steps after checking the rule, and consider the work done when the rule's necessity is established without regressing the playback notification.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
build-system, mobile
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.