Automattic / Automattic/o2

Events: applyFilters() supports only callbacks for all arguments

Open
#104 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
338
Forks
56
Avg merge
24m
Merged PRs (30d)
16

Description

See [this line](https://github.com/Automattic/o2/blob/9a8be6b17fbfe4c4cb55ac88597020d89279057d/js/utils/events.js#L138): If a filter provides two arguments but your callback needs only the first one the callback doesn't get called.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at applyFilters() in js/utils/events.js around line 138 and reproduce the case where a filter supplies two arguments but the callback accepts only the first. Done means the callback is invoked with the usable arguments in that case, while existing filter behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.