Automattic / Automattic/node-canvas

Non-standard `patternQuality` used instead of `imageSmoothingQuality`

Open
#2,114 1 comment 1 reaction 0 assignees View on GitHub
Bug
Dominant language
JavaScript
Stars
10.7k
Forks
1.2k
Avg merge
4d 8h
Merged PRs (30d)
1

Description

## Issue or Feature
`imageSmoothingQuality` is a [standard feature](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/imageSmoothingQuality) with values `'low'|'medium'|'high'`. In `drawImage()`, node-canvas currently uses its non-standard `patternQuality` prop, which has values `'fast'|'good'|'best'|'nearest'|'bilinear'`:

https://github.com/Automattic/node-canvas/blob/b3e7df319c045c1dc74e390f4b3af161304c9c55/src/CanvasRenderingContext2d.cc#L1376

`patternQuality` is used elsewhere also, so it can't just be renamed and re-valued.

## Your Environment
* Version of node-canvas (output of `npm list canvas` or `yarn list canvas`): 2.10.1
* Environment (e.g. node 4.2.0 on Mac OS X 10.8): all

Relates to #2067

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.