Automattic / Automattic/node-canvas

Make img.src= async, add non-standard img.load() synchronous API

Open
#1,007 0 comments 4 reactions 0 assignees View on GitHub
Bug Feature semver-major
Dominant language
JavaScript
Stars
10.7k
Forks
1.2k
Avg merge
4d 8h
Merged PRs (30d)
1

Description

See discussion in https://github.com/Automattic/node-canvas/pull/1003#issuecomment-330417446 and the next comment.

`img.src=` should be async to follow browser behavior. We can keep a non-standard synchronous API for flexibility though, something like `img.src(buffer|string)`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.