Automattic / Automattic/nginx-http-concat

Assets that skip concatenation should still get an `mtime`

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
120
Forks
37
PR merge metrics
No merged PRs in 30d

Description

If something isn't concatenated, it bypasses the addition of an `mtime` as well, which can lead to stale versions of those assets remaining in cache: https://github.com/Automattic/nginx-http-concat/blob/2239f115f3da6d09c8660db65163a08e55d0348c/cssconcat.php#L107.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in cssconcat.php around line 107, where non-concatenated assets bypass the mtime addition. Trace that path and verify that an mtime is still included for assets that skip concatenation, so cached assets can be invalidated when they change.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.