Automattic / Automattic/kue

watchStuckJobs uses the KEYS command

Open
#1,075 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9.4k
Forks
858
PR merge metrics
No merged PRs in 30d

Description

Hello,

While debugging some performance issues I looked at the watchStuckJobs implementation and saw kue uses the KEYS redis command. Redis recommends that this command should be avoided in production environment due to its complexity (O(n) on the number of keys). https://redis.io/commands/keys

Could you fix this? Or at least stop strongly suggesting using this command? The performance impact is significant with a big enough database.

Regards

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating and reading the watchStuckJobs implementation, then trace how it discovers Redis keys and review the Redis KEYS guidance linked in the issue. Check existing tests around stuck-job watching if present. Done means the implementation no longer strongly recommends or relies on the problematic command and its behavior remains covered by verification.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, redis
Domain
backend, databases, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.