Automattic / Automattic/knox

putFile/putStream API should handle HTTP 307 redirects from AWS S3

Open
#66 31 comments 2 reactions 0 assignees View on GitHub
feature
Dominant language
JavaScript
Stars
1.7k
Forks
283
PR merge metrics
No merged PRs in 30d

Description

I totally get the "low level" knox API should leave this kind of handling to the client. But I wanted to suggest that the "high level" knox S3 API handle the cases where AWS S3 returns a HTTP `307` status code.

The Amazon's S3 doc says:

```
If you create a bucket using , applications that access your
bucket must be able to handle 307 redirects."
```

This happened to me when I used LearnBoost/knox#53 a few minutes after creating a new bucket in AWS to use. Once DNS is sync'd with S3, the case is likely more rare.

Obviously there are "workarounds" for this, but wanted to bring it up since knox is working pretty well for me otherwise! Thanks!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the putFile and putStream API entry points and trace how they handle AWS S3 responses, focusing on HTTP 307 redirects during uploads. Confirm the behavior with a reproducible redirect case or relevant tests; done means both APIs handle the redirect rather than failing or requiring a client workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, javascript
Domain
api, cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.