Automattic / Automattic/knox

File with parentheses in the name should not be encoded during signing

Open
#282 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.7k
Forks
283
PR merge metrics
No merged PRs in 30d

Description

When signing a url using Knox.signedUrl(fileName, expires), a file name with parentheses has the parentheses encoded as %28 "(" and %29 ")" and produces a file name that doesn't work. If the parentheses encoding is replaced with the original parentheses, url then works.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the implementation of Knox.signedUrl(fileName, expires) and trace how the file name is encoded during signing. Verify the resulting URL preserves parentheses instead of converting them to %28 and %29, and confirm that the signed URL works for such a file name.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.