Automattic / Automattic/knox

FIx test/sample code for signed upload url

Open
#279 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.7k
Forks
283
PR merge metrics
No merged PRs in 30d

Description

Example/test code for Signed PUT url is wrong

https://github.com/Automattic/knox/blob/master/test/signedUrl.test.js#L78

'x-amz-acl' goes in extraHeaders argument and is not a direct argument by itself

Contributor guide

No contributing guide indexed for this repository

Research direction

Open test/signedUrl.test.js around line 78 and inspect the signed PUT URL example/test. Move 'x-amz-acl' into the extraHeaders argument rather than treating it as a direct argument, then run the relevant signed URL test to confirm the example uses the correct call.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.