Automattic / Automattic/knox

Invalid signedUrl when filename contains parantheses

Open
#242 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.7k
Forks
283
PR merge metrics
No merged PRs in 30d

Description

AWS S3 returns SignatureDoesNotMatch error because it asks for %28 and %29 in StringToSign but the Client.prototype.signedUrl function (https://github.com/LearnBoost/knox/blob/master/lib/client.js#L858) does not URL-encode "()" characters

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in lib/client.js at the signedUrl function around line 858 and inspect how filenames are encoded before signing. Reproduce the issue with a filename containing parentheses, then verify that the generated URL and StringToSign use the expected encoding and that S3 no longer returns SignatureDoesNotMatch.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, javascript
Domain
backend, cloud
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.