Automattic / Automattic/juice

Code blocks not fully ignored when in `style` tag

Open
#405 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.3k
Forks
233
Avg merge
1d 10h
Merged PRs (30d)
8

Description

Hi,
I'm using juice to pack an HTML file which uses Handlebars, and I found what seems to be a bug. Here's the [reproduction](https://runkit.com/embed/jzmmmgmx0tf0).

To sum it up, if we process the following HTML:
```

.somediv {
color: blue;
}


```

You can see that the second example is missing its closing `{{/if}}`
I tried playing around and adding several, more specific, options to `codeBlocks`, but to no avail.

Contributor guide

Open the contributing guide

Research direction

Start with the linked RunKit reproduction and inspect how Juice processes style-tag contents and the codeBlocks option. Compare both Handlebars examples; done means the second example retains its closing {{/if}} after CSS inlining.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, handlebars, javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.