Automattic / Automattic/jetpack

Sharing: When switching site language, switch sharing label's language automatically

Open
#7,469 1 comment 0 reactions 0 assignees View on GitHub
[Feature] Sharing [Focus] i18n [Pri] Low [Status] Stale Bug
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

When switching a site's language, the Sharing label remains in the language the blog was originally created.

Ideally, when a user switches the site's language, the label's language should change automatically to save the user from having to figure out where to change the text.

#### Steps to reproduce the issue

1. Create a site with the language set to English US.
2. Go into Settings > General and select a language for which Jetpack is fully translated – such as French France (FR_fr) – and activate it.
3. Activate the Sharing module and set the sharing icons to display on posts.
4. Visit a post on the front end.

#### What I expected

The label above the sharing icons should be in French.

#### What happened instead

The label above the sharing icons was still in English.

Replicated in multiple themes in multiple languages, here are two examples:

![share this string localization i18n _ glob l_](https://user-images.githubusercontent.com/7662449/28279288-04b8b3e8-6aee-11e7-8d4e-8a422bac4bf1.png)

The only way to modify the sharing label's language at this point is to manually go into Sharing Settings and adjust the text by hand there:

**WP Admin**

![sharing settings a lovely site wordpress](https://user-images.githubusercontent.com/7662449/28279638-13397190-6aef-11e7-995d-4072ece1f2d2.png)

**Calypso**

![sharing a lovely site wordpress com](https://user-images.githubusercontent.com/7662449/28279733-71cede84-6aef-11e7-811a-864b48e92f89.png)

No written user report, I noticed the issue while helping a user in person at a local WordPress event.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue through Settings > General, the Sharing module, and the post front end, checking both WP Admin and Calypso settings. Trace how the sharing label is stored and localized when the site language changes; done means the label follows the selected site language without manual editing, with the reported English-to-French case behaving as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.