Automattic / Automattic/jetpack

Domain IP check not reliable

Open
#7,069 1 comment 0 reactions 0 assignees View on GitHub
[Pri] Low Enhancement General
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

#### Steps to reproduce the issue
- Use latest VVV to share a host on a public IP
- Try to connect

#### What I expected
- Connection works

#### What happened instead
- Error like "Domain `my.vvv.site.vagrant.com` just failed is_usable_domain check as its IP `127.0.0.1` is either invalid, or in a reserved or private range."

This is happening because Vagrant resolves the public domain to 127.0.0.1 on the server, but it still has a valid public IP as well. Connecting should work. We should rely on WordPress.com to tell us if a domain can be resolved to a public IP or not.

Contributor guide

Open the contributing guide

Research direction

No file or test is named in the issue. Reproduce the VVV setup with a host on a public IP and trace the domain usability check that rejects 127.0.0.1. Done means the connection works and WordPress.com determines whether the domain resolves to a public IP.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
backend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.