Automattic / Automattic/jetpack
Jetpack_Sync_Module_Options::get_all_options() returns non-existing wp_options
Open
[Package] Sync
[Pri] Normal
[Status] Stale
Bug
- Dominant language
- PHP
- Stars
- 1.8k
- Forks
- 898
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 774
Description
If an option doesn't exist in the wp_options table, it'll still be sent (as an empty value) in the full_sync action.
To reproduce:
- Add a non-existing option to the whitelist, or delete an existing option
- Run a full sync
- Observe the option being sent
Contributor guide
Research direction
Start by tracing Jetpack_Sync_Module_Options::get_all_options and the full_sync action, then reproduce the case with a whitelisted option missing from wp_options. Done means missing options are omitted from the full_sync payload rather than sent with an empty value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100