Automattic / Automattic/jetpack

Newsletters: allow classic themes to preview or edit modals

Open
#37,980 0 comments 0 reactions 0 assignees View on GitHub
[Feature] Subscriptions Enhancement
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

We allow customers to enable modals and few other things in classic themes, but since preview/editing happens in the template editor, we don't allow them to edit them:

Block themes:
Screenshot 2024-06-21 at 14 29 54

Classic themes:
image

We could however:
- Explore allowing edit links if classic theme declares `add_theme_support( 'block-template-parts' );`
- Add copy indicating that with more modern theme they could preview/edit the modals. Perhaps in a popover.
- Add preview links which are just static links to the site, but with some URL attribute forcing the modals to show up even if they're disabled, e.g. `?jetpack-preview-welcome-overlay` etc

Came up in p1718967449951009-slack-C052XEUUBL4

Contributor guide

Open the contributing guide

Research direction

Start by locating the Newsletter modal settings and the template-editor entry points for classic themes. Review how block-template support and modal preview links are handled, then confirm which proposed approach is selected; done means classic-theme customers can preview or edit the modals with clear guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.