Automattic / Automattic/jetpack

Enhancement: Various VideoPress shortcode setting fixes

Open
#3,655 3 comments 0 reactions 0 assignees View on GitHub
[Feature] VideoPress Enhancement
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

As @jeherve suggested in https://github.com/Automattic/jetpack/pull/3646#issuecomment-209419213
- [ ] Review whether Flash is needed in the dialog and what happens to other choices if it's ticked
- [ ] Reword autoplay label
- [x] Make video in editor responsive. Done in https://github.com/Automattic/jetpack/pull/3646/commits/ef7b3d3dfb9b8babafdd237c1926a3579d840669
- [ ] Implement a time field for the video time offset
- [ ] Move `tinyMCE.ui.FormItem.prototype.renderHtml` into `onopen` [see comment](https://github.com/Automattic/jetpack/pull/3646#discussion-diff-59735692).
#

I played with this, and the improvements look nice. I think we could still improve a few other things, though:
### Flash

That old player doesn't include all the other options available in the modal, so it makes things a bit confusing. I shouldn't be able to select both "Open Source Codecs" and Flash, or Autoplay and Flash. If usage of the old flash player is not recommended, why adding it to the modal? Shouldn't we only leave it as a shortcode parameter instead, for legacy?
### Autoplay

Wouldn't it be less confusing to just call it "autoplay", or "autoplay this video", like YouTube and Vimeo do? "Autoplay video on page load seems more complicated than it should be.

![screen shot 2016-04-13 at 2 50 08 pm](https://cloud.githubusercontent.com/assets/426388/14493711/0cb19a00-0187-11e6-9457-eb16e2af1bf9.png)

![screen shot 2016-04-13 at 2 49 31 pm](https://cloud.githubusercontent.com/assets/426388/14493705/020d17dc-0187-11e6-9ba5-0b0f6bc0effd.png)

I think "Loop" could also be simplified, like on Vimeo. Words like "page load" and "playback" will only make things more confusing for users imo.
### Layout issues

Although I use a theme including a post editor stylesheet (Twenty Sixteen), the VideoPress embed is larger than the editor. Is that to be expected?

![screen shot 2016-04-13 at 2 42 57 pm](https://cloud.githubusercontent.com/assets/426388/14493497/0a41bb0c-0186-11e6-8be7-3c88aa445503.png)
### Video offset

Would there be a way to make this more user-friendly?

![screen shot 2016-04-13 at 2 45 36 pm](https://cloud.githubusercontent.com/assets/426388/14493578/70e7e480-0186-11e6-8647-b9648cd99609.png)

Right now, I can only enter seconds ("how many seconds is 1:35?"), and I can enter just about any random number.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing PR 3646 and its discussion, then inspect the VideoPress shortcode dialog and editor settings, including the tinyMCE.ui.FormItem.prototype.renderHtml path mentioned in the issue. Done means resolving the remaining Flash-option behavior, simplifying the autoplay and loop labels, adding a user-friendly video offset field, and confirming the editor layout remains responsive.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php, wordpress
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.