Automattic / Automattic/jetpack

Conflicting plugins: improve the way we handle conflicting plugins

Open
#354 3 comments 0 reactions 1 assignee Claimed by @georgestephanis View on GitHub
[Feature] Publicize [Feature] Sharing Enhancement Good For Community
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

At the moment, we use 2 functions, `check_open_graph` ([#](https://github.com/Automattic/jetpack/blob/2.9.1/class.jetpack.php#L630)) and `check_twitter_tags` ([#](https://github.com/Automattic/jetpack/blob/2.9.1/class.jetpack.php#L702)) to check if a conflicting plugin is active, and deactivate the Open Graph Tags or the Twitter Cards if we find a conflicting plugin.

There are a few problems with our existing approach:
- Some of the code is duplicated in both of these functions
- If we disable Open Graph Tags, Twitter Cards also get disabled as well since they're hooked into the Open Graph tags ([#](https://github.com/Automattic/jetpack/blob/2.9.1/functions.twitter-cards.php#L133)) - [#2052-plugins](https://plugins.trac.wordpress.org/ticket/2052)
- A conflicting plugin can be activated while its Open Graph functions are not active. It would nice to detect that (#53).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.