Automattic / Automattic/jetpack

VideoPress: Private videos do not display anything when rendered for email

Open
#34,099 2 comments 0 reactions 0 assignees View on GitHub
[Block] VideoPress [Pri] Normal [Status] Stale Bug
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

When VideoPress videos are rendered on email (see D126650-code), there is no distinction for public and private videos. When the video is private, its poster image is also private and the email client fails to load it due to a `403` response. This makes the video end up being rendered as an empty space:

![Image](https://github.com/Automattic/jetpack/assets/8486249/ca3a29e4-4de1-4397-90d1-a9ce4ecdb2a3)

We need to check if the video is private and, if so, display _something else_ instead. Either a static placeholder or a simple text link.

Contributor guide

Open the contributing guide

Research direction

Start with the email-rendering implementation referenced by D126650-code and trace how VideoPress videos and poster images are rendered. Confirm the private-video case against an email client or rendering test, then make the result show either a static placeholder or a simple text link instead of an empty space.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.