Automattic / Automattic/jetpack
Bug: Videopress Fullscreen Toggle Not Working Correctly
- Dominant language
- PHP
- Stars
- 1.8k
- Forks
- 898
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 774
Description
There seems to be an issue with the fullscreen toggle in the latest videopress version. The built does not get the correct fullscreen attributes. This issue might originate from this line of code:
https://github.com/Automattic/jetpack/blob/666d612b1bef125096cdbf90125ce04a72be49a5/projects/packages/videopress/src/class-block-editor-content.php#L121
When using the Gutenberg Videopress Embed Blog in Production I cannot toggle fullscreen.
When using it inside of The Gutenberg Blocker Editor mode i can toggle it succesfully
Contributor guide
Research direction
Start at projects/packages/videopress/src/class-block-editor-content.php around line 121 and compare the iframe attributes produced in production with those used in the Gutenberg block editor. Verify the fullscreen attributes are present in the built iframe and confirm that the production Videopress embed can toggle fullscreen.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100