Automattic / Automattic/jetpack

Subscriptions block: Remove option to place button on new line when using compact style

Open
#28,226 1 comment 1 reaction 0 assignees View on GitHub
[Block] Subscribe [Plugin] Jetpack Enhancement
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

### Impacted plugin

Jetpack

### Issue

After adding a Subscriptions block in the editor and selecting 'Compact' under the Styles, there is still an option to place the button on a new line under 'Settings' in the sidebar. This has exactly the same effect as choosing 'Split' instead of 'Compact', so seems redundant and confusing.

Screen Shot 2023-01-09 at 11 29 27 am

Could that option be removed when 'Compact' is selected?

Mentioned in internal testing: p8oabR-11U-p2#comment-6963

Contributor guide

Open the contributing guide

Research direction

Start in the Jetpack Subscriptions block's editor Styles and sidebar Settings controls, comparing the Compact and Split options described in the issue. Verify the sidebar no longer offers the new-line button option for Compact, while the equivalent Split behavior remains available, then confirm the block still renders correctly in the editor.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.