Automattic / Automattic/jetpack
Google Docs Embed Block: Primary issue
- Dominant language
- PHP
- Stars
- 1.8k
- Forks
- 898
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 774
Description
- [ ] Ensure private preview notice works well with dark themes https://github.com/Automattic/jetpack/pull/24628#pullrequestreview-1041412672
- [ ] Switch to `@automattic/jetpack-base-style` https://github.com/Automattic/jetpack/pull/24628#discussion_r920868643
- [ ] Ensure labels can be translated https://github.com/Automattic/jetpack/pull/24628#discussion_r934321936
- [ ] Add tests for the block. See other blocks (e.g. Subscriptions) for some examples.
- [ ] Add test for `map_gsuite_url` https://github.com/Automattic/jetpack/pull/24628#discussion_r934328642
********
Internal references:
- pdqkMK-ch-p2
- Previous art on P2s: 2485-gh-p2
********
cc @gthayer
Contributor guide
Research direction
Start with the Google Docs Embed Block and review the referenced pull request discussions for the outstanding decisions. Use the Subscriptions block as the testing example and locate the map_gsuite_url entry point. Done means all five checklist items are addressed, including translated labels, dark-theme behavior, base-style usage, and block and URL-mapping tests.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100