Automattic / Automattic/jetpack
Should search plugin respect module status overridden?
- Dominant language
- PHP
- Stars
- 1.8k
- Forks
- 898
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 774
Description
Jetpack modules have a mechanism that allows modules to be forced off/on by a filter which is used by VIP (not sure if there are any other occasions).
Just file this to see if we need to do anything.
https://github.com/Automattic/jetpack/blob/e3a2ad389fb0f0441ecf7611f972f7c2f6668d43/projects/plugins/jetpack/class.jetpack-admin.php#L184
https://github.com/Automattic/jetpack/blob/e3a2ad389fb0f0441ecf7611f972f7c2f6668d43/projects/plugins/jetpack/_inc/client/components/module-toggle/index.jsx#L89
Contributor guide
Research direction
Start with projects/plugins/jetpack/class.jetpack-admin.php around line 184 and _inc/client/components/module-toggle/index.jsx around line 89. Trace how module status overrides reach the search plugin and determine the expected behavior for forced-on and forced-off modules. Done means the behavior is agreed and covered by the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php, react
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100