Automattic / Automattic/jetpack

Search: Improve messaging for the overlay close button on Customberg

Open
#22,517 0 comments 0 reactions 0 assignees View on GitHub
[Feature] Search [Package] Search [Plugin] Jetpack [Plugin] Search [Pri] Low Enhancement Instant Search Triaged
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

### Impacted plugin

Jetpack

### Steps to Reproduce

1. On a site with a Jetpack Search subscription with Instant Search enabled, navigate to Customberg (`/wp-admin/admin.php?page=jetpack-search-configure`).
2. Click on the `X` adjacent to the search box in the Instant Search application:
Screen Shot 2022-01-26 at 5 16 11 PM

### A clear and concise description of what you expected to happen.

`X` should either:
- indicate it's not an interactable element
- take the user back to the last page in the browser history stack

### What actually happened

`X` is clickable, but doesn't do anything besides drawing an outline on the button.

### Other information

_No response_

### Operating System

_No response_

### OS Version

_No response_

### Browser

Chrome/Chromium

### Browser Version(s)

_No response_

Contributor guide

Open the contributing guide

Research direction

Start at the Customberg entry point in /wp-admin/admin.php?page=jetpack-search-configure and reproduce the Instant Search overlay behavior in Chrome/Chromium. Inspect the X adjacent to the search box and clarify whether the intended outcome is a non-interactable control or navigation to the previous browser-history page; done means the selected behavior is implemented and the outline-only action no longer occurs.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.