Automattic / Automattic/jetpack
Jetpack Sync: PHP notice for checksum process
- Dominant language
- PHP
- Stars
- 1.8k
- Forks
- 898
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 774
Description
> there’s a big spike in these notices from Jetpack today: “Undefined index: shared_salt”
https://github.com/Automattic/jetpack/blob/e60446527adaedf8ad10ee43456a068669c2bc87/projects/plugins/jetpack/json-endpoints/jetpack/class.jetpack-json-api-sync-endpoint.php#L116
This happens whether the site runs 9.5 or 9.6.
Reported here:
https://wordpress.org/support/topic/spike-in-these-all-of-a-sudden-undefined-index-shared_salt/
------
@bisko @mdbitz Do you think you could take a look?
Contributor guide
Research direction
Start at projects/plugins/jetpack/json-endpoints/jetpack/class.jetpack-json-api-sync-endpoint.php around line 116 and trace how shared_salt is accessed during checksum processing. Compare the reported behavior on Jetpack 9.5 and 9.6; done means the sync endpoint no longer emits the Undefined index: shared_salt notice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100