Automattic / Automattic/jetpack
Jetpack Carousel + CoBlocks Lightbox conflict
- Dominant language
- PHP
- Stars
- 1.8k
- Forks
- 898
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 774
Description
#### Steps to reproduce the issue
**Ensure that Jetpack Carousels are enabled and the CoBlocks plugin is installed and active**
1. Create a new page or open an existing page
2. Insert Gallery block
3. Add images to Gallery block
4. On the right, leave lightbox feature disabled
5. Publish the page, click on an image in the gallery.
#### What I expected
When Lightbox is disabled, I would expect no lighbox _or carousel_ when you click on the image. Most users don't know the difference between Lightbox and Carousel.
#### What happened instead
If lightbox is disabled, the Jetpack carousel still shows - this appears to be misleading to our users
If lightbox is enabled, a carousel will first show, then when you close out of that the lightbox will show, I don't believe any user would expect that to occur.
It seems the workaround would be to disable the Jetapack carousel feature since this is a whole site setting (you can't turn it on/off for specific gallery blocks) and to toggle on/off the CoBlocks Lightbox feature on each gallery, but this is in no way apparent to our users.
**Screenshots**
Here's a GIF recording I took showing the issue:
https://d.pr/i/VYgTyT/ZKcOwkvn4T
Of note, the lightbox controls were introduced here: https://github.com/godaddy-wordpress/coblocks/pull/1557
If this suggestion is implemented, this would likely help clear things up I think: https://github.com/Automattic/jetpack/issues/15946
Contributor guide
Research direction
Reproduce the conflict with Jetpack Carousels enabled and CoBlocks active, following the gallery and lightbox steps in the issue. Read the linked CoBlocks pull request 1557 and Jetpack issue 15946 for related context; done means clicking a gallery image does not produce an unexpected carousel and lightbox sequence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, wordpress
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100