Automattic / Automattic/jetpack

Gardening: Remove [Plugin] label when no longer applicable

Open
#19,494 1 comment 0 reactions 0 assignees View on GitHub
[Action] Repo Gardening [Pri] Low New Feature
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

In https://github.com/Automattic/jetpack/pull/18608 a test plugin that was in `projects/plugins/` was accidently committed and pushed. This created a new label via the Gardening action (cool), but was removed later. The end result was a PR that didn't touch any plugin.

The label remained which ended up throwing an error for the milestone action since there was no milestone for that plugin (since it wasn't supposed to be a plugin).

Could/should we remove the Plugin label when there is no longer any touched code?

cc: @jeherve

Contributor guide

Open the contributing guide

Research direction

Review the Gardening action and milestone action referenced in the issue, starting with the behavior that creates and retains the Plugin label. Trace how touched plugin code is determined and how the label is consumed; done means a PR with no remaining plugin code no longer retains that label or causes a milestone error.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.