Automattic / Automattic/jetpack

Instant Search: wait until text edit is complete before spawning overlay

Open
#18,581 1 comment 1 reaction 0 assignees View on GitHub
[Feature] Search [Plugin] Jetpack [Plugin] Search [Pri] Low Enhancement Instant Search Triaged
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

#### Steps to reproduce the issue

1. Go to a site with Instant Search enabled.
2. Type in a query in an input box, like 'huskies'
3. Close the modal
4. Delete one character of the search term

#### What I expected
The search modal is not spawned until I've completed my edit (e.g. deleted 3 characters).

#### What happened instead
The search modal is speedily spawned immediately after I type or delete each character.

Discovered while testing https://github.com/Automattic/jetpack/pull/18574.

![2021-01-28 14-58-15 2021-01-28 15_00_28](https://user-images.githubusercontent.com/17325/106079187-9b566680-6179-11eb-89a8-1e5277c9cd0d.gif)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the listed sequence on a site with Instant Search enabled and observe when the modal appears after editing the query. The work is done when the modal waits until the text edit is complete rather than spawning after each typed or deleted character.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.