Automattic / Automattic/jetpack

Consider using require_once in the masterbar module

Open
#17,774 0 comments 0 reactions 0 assignees View on GitHub
[Feature] Masterbar [Type] Janitorial
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

Does it matter if this is `require` or `require_once`? Jetpack seems to support `__DIR__ `, in case that is something you want to change.

_Originally posted by @obenland in https://github.com/Automattic/jetpack/pull/17762#discussion_r520677542_

Contributor guide

Open the contributing guide

Research direction

Locate the masterbar module and inspect the require call mentioned in the issue. Check how nearby Jetpack modules handle repeated loading and __DIR__, then verify the module’s existing tests or loading path. Done means the loading approach is consistent and the masterbar still loads without duplicate-inclusion problems.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.