Automattic / Automattic/jetpack

Donations block: Avoid inserting inline images on the donate buttons

Open
#16,999 0 comments 0 reactions 0 assignees View on GitHub
[Block] Donations Earn Enhancement Payments: before Woo
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

This is a follow-up to https://github.com/Automattic/jetpack/issues/16887 and reported by @Luchadores in p58i-9k2-p2#comment-47420.

The block toolbar offers an option for inserting an inline image to the donate button that can result in a weird UI.

Screen Shot 2020-08-27 at 15 10 12

![image](https://user-images.githubusercontent.com/1233880/91446214-77fc5800-e877-11ea-9452-429ff65868bb.png)

From a conversion point of view, it may be better to remove that option entirely so users have something that works in all situations.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Donations block and the block-toolbar controls that allow inline images on donate buttons. Remove or disable that option, then verify that donate buttons no longer offer inline-image insertion and that their UI remains usable in the situations shown by the issue screenshots.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, wordpress
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.