Automattic / Automattic/jetpack

Submit button styles break theme styles

Open
#15,841 4 comments 0 reactions 0 assignees View on GitHub
[Block] Calendly [Block] Mailchimp [Block] Payment Button Enhancement
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

Hi

The inline css styles on button borders are breaking theme editor styles.

https://github.com/Automattic/jetpack/blob/5ddf14cdaf5b45f3e4e05e1c4c96bb72f3556c46/extensions/shared/submit-button.js#L91

You can see an example in the image below:

cv6P3l1dzM

Can we remove this rule? It seems very specific and the only way I can see to fix it is to use _!important_ rules, which could have issues with custom colours elsewhere.

Contributor guide

Open the contributing guide

Research direction

Start in extensions/shared/submit-button.js at line 91 and inspect the inline CSS applied to the button borders. Remove the rule that overrides theme editor styles, then verify that theme button styling is no longer broken without relying on !important rules.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.