Automattic / Automattic/jetpack

Eventbrite: Hidden Anchor Outside Block Wrapper in Markup

Open
#15,518 0 comments 0 reactions 0 assignees View on GitHub
[Block] Eventbrite [Pri] Normal [Size] S Bug
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

I've noticed the hidden `a.eventbrite__direct-link` is outside of the `div.wp-block-jetpack-eventbrite`. Can the hidden link inside of the wrapper so that the wrapper is the outermost element?

Screenshot 2020-04-22 at 12 06 33

**Motivation**: Lots of themes remove the top margin of the first element inside a block such as column block. However, the hidden link being the first element in the markup, it prevents themes to remove the top margin and causing a misalignment on the front of the site.

Screenshot 2020-04-22 at 12 04 16

Contributor guide

Open the contributing guide

Research direction

Start by locating the Eventbrite block markup and inspect the rendered order of the hidden a.eventbrite__direct-link and div.wp-block-jetpack-eventbrite wrapper. Done means the wrapper is the outermost element, the hidden link is inside it, and the frontend no longer shows the reported top-margin misalignment.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.