Automattic / Automattic/jetpack
Avoid using strings 'off' and 'on' as booleans.
Open
[Feature] Likes
[Feature] Subscriptions
[Type] Good First Bug
Enhancement
- Dominant language
- PHP
- Stars
- 1.8k
- Forks
- 898
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 774
Description
This is a continuation of #14240, we need to stop using `on` and `off` strings as booleans in options.
#### Steps to reproduce the issue
1. Go to the Likes and Subscriptions modules, see that some of the options are set as `on` and `off`.
2. Feel that it's wrong.
3. Realize that they should probably be `true` and `false`.
Contributor guide
Research direction
Start by inspecting the Likes and Subscriptions modules and locating the options that currently use the `on` and `off` strings. Compare the related discussion in issue #14240, then verify that the affected options use `true` and `false` consistently and that no `on` or `off` boolean values remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, wordpress
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100