Automattic / Automattic/jetpack

Repeat Visitor: allow wide/full alignment

Open
#14,219 2 comments 0 reactions 0 assignees View on GitHub
[Block] Repeat Visitor [Focus] Blocks Enhancement
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

I noticed that when blocks (eg: cover block) that can be set to wide or full alignment are nested within a Repeat Visitor block are set as such (ie: wide or full), then the entire Repeat Visitor block doesn't show up at all on the front end - at least on wpcom. Or if the block does show, then the full/wide alignment of the nested block isn't respected.

Would it be possible to allow the Repeat Visitor block to have wider alignments?

The reason I'm asking is because I think it could get a lot of use as a "splash page" function. On the wpcom side of things I've encountered a couple of people asking how to add a splash page and I really think that we could help them achieve that kind of effect using just a block set to disappear after the initial visit.

I made a quick example here, complete with page jump "enter" button to scroll down to the main site contents:
https://temp87765.wordpress.com/

The reason the question came up was because I wanted to nest the main site contents in **another** repeat visitor block - the "find out more" button there could instead be just a link to the front page again, effectively refreshing it and pushing the visitor past the first-visit threshold which I'd set the "splash" Repeat Visitor block to hide after, and the main site contents to show instead. As you can see, I've got a full-width cover block there, and nothing shows currently if I nest that content within a repeat visitor block.

Contributor guide

Open the contributing guide

Research direction

Start from the Repeat Visitor block and reproduce the issue with a nested Cover block set to wide or full alignment, using the linked example as context. Check the front-end result and verify that the Repeat Visitor content renders and preserves the nested block's wider alignment.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.