Automattic / Automattic/jetpack

Plan Icon: Update and use the component on My Plan page

Open
#14,126 4 comments 0 reactions 2 assignees Claimed by @mattgawarecki View on GitHub
[Pri] Low [Status] Blocked / Hold Admin Page Plans
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

#### Problem
Even though currently there is a [`PlanIcon` component](https://github.com/Automattic/jetpack/tree/8d8cbec66b759759207bab4300098353237bd894/_inc/client/components/plans/plan-icon) in the codebase, it's used only in the [`Banner` component](https://github.com/Automattic/jetpack/blob/2fee69dd0a32f6e353cc4d47417d7ac8aa83b9c6/_inc/client/components/banner/index.jsx#L83).

Ideally we would use it in every time a plan icon is used, e.g. on the My Plan page ([instead of using hard-coded images paths](https://github.com/Automattic/jetpack/blob/master/_inc/client/my-plan/my-plan-header/index.js#L42)).

The problem is that those icons are different visually. E.g. here's the Personal plan icon rendered by `PlanIcon`:

Screenshot 2019-11-26 at 10 24 42

And here's the same Personal plan icon rendered on My Plan page:

Screenshot 2019-11-26 at 10 25 52

I guess the second icon is the most up-to-date.

#### Solution
- [ ] Update `PlanIcon` to use the new icons for each plan
- [ ] Add Jetpack Backup icons to `PlanIcon`
- [ ] Replace the hard-coded icons on My Plan page with the `PlanIcon`
- [ ] *Optionally:* rename the `PlanIcon` to `ProductIcon` so that it's more generic

#### Additional context
This has been discovered when working on adding Jetpack Backup to the My Plan page ([here's the relevant PR](https://github.com/Automattic/jetpack/pull/14121)).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.