Automattic / Automattic/jetpack

Disconnect Dialog: handle extremely large numbers

Open
#13,916 1 comment 0 reactions 0 assignees View on GitHub
[Pri] Low Admin Page Enhancement
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 14h
Merged PRs (30d)
790

Description

* Start from a connected Jetpack site, where the Stats module is active and you've had visitors already.
* In Jetpack > Dashboard, click on the link to manage the site connection.
* In the modal that opens, if the stats has a lot of stats, the layout may break:

screenshot 2019-10-31 at 17 35 44

* The same holds true for other cards.

Maybe we should make sure that when we have huge numbers, we switch to a different format, like maybe letters like `k` for thousands?

Contributor guide

Open the contributing guide

Research direction

Start from a connected Jetpack site with the Stats module active, then reproduce the layout break through Jetpack > Dashboard and the site-connection management link. Inspect the Disconnect Dialog and its cards, including the Stats card, and verify that very large values no longer break the modal layout and are displayed in a readable compact format.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.