Automattic / Automattic/jetpack

Sharing: make sure the "More" button label match what will be displayed on the frontend

Open
#1,390 1 comment 0 reactions 0 assignees View on GitHub
[Feature] Sharing [Type] Good First Bug Enhancement Hacktoberfest
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

Steps to reproduce:
1. Go to Settings > Sharing
2. Place sharing buttons in the hidden sharing area:
![screen shot 2014-12-10 at 8 42 34 am](https://cloud.githubusercontent.com/assets/426388/5372409/854f8e20-8048-11e4-90ed-dc317981501a.png)
- In the preview, the button uses "More" as a label
3. Save your changes, visit your site:
![screen shot 2014-12-10 at 8 43 24 am](https://cloud.githubusercontent.com/assets/426388/5372416/9ee15cc4-8048-11e4-9807-b20ba3bc4db5.png)
- The button uses "Share" as a label, [as expected](https://github.com/Automattic/jetpack/blob/3.2.1/modules/sharedaddy/sharing-service.php#L570)

It'd be nice if the admin preview was adjusted to match what will be displayed on the frontend.

Contributor guide

Open the contributing guide

Research direction

Start in the Settings > Sharing admin preview and compare its “More” label with the frontend behavior described in the issue. Check the referenced modules/sharedaddy/sharing-service.php at line 570; done means the preview and saved site display the same label.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.