Automattic / Automattic/jetpack

Jetpack Settings: Get rid of "Save Settings" card buttons

Open
#12,829 3 comments 2 reactions 0 assignees View on GitHub
[Pri] Low Admin Page Customer Report [LEGACY] Enhancement
Dominant language
PHP
Stars
1.8k
Forks
898
Avg merge
1d 18h
Merged PRs (30d)
774

Description

"Save Settings" buttons that present for some of the settings cards used only for cards with selects, radio buttons and inputs. All the toggles trigger auto-save on click. I find current Save behavior inconsistent, which is confusing.

I think we can get rid of "Save Settings" buttons altogether, and add auto-save behavior to other control elements (radio buttons, selects, etc)

FWIW the current behavior is similar to Calypso settings. So it might not be an easy task if we still want to maintain the same behavior between wp-admin & Calypso

#### Steps to reproduce the issue

1. Go to Jetpack Settings
2. Find a card with "Save Settings" button
3. Try to make that button become active

![screencast 2019-06-24 13-23-47](https://user-images.githubusercontent.com/5654161/60012447-a59ead80-9684-11e9-948e-700f2b7730a6.gif)

Contributor guide

Open the contributing guide

Research direction

Start at the Jetpack Settings cards described in the issue and compare their wp-admin and Calypso behavior. Done means removing all Save Settings buttons and autosaving radio buttons, selects, and inputs while keeping the two settings surfaces consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, wordpress
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.