Automattic / Automattic/jetpack-force-2fa

Match By Email should be disabled

Open
#19 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
7
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Since we hardcode the set by email option, the checkbox should be disabled. After checking in wp-cli, `Jetpack_SSO_Helpers::is_match_by_email_checkbox_disabled()` returns the correct value. It seems like `render_match_by_email()` is not firing, but I'm not sure where that field is coming from then.

https://github.com/Automattic/jetpack/blob/5c4fd63e63cdcb380a16d33a591a265ca6b4318e/modules/sso.php#L291

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in modules/sso.php around the linked line and trace how the Match By Email field is rendered, comparing that path with Jetpack_SSO_Helpers::is_match_by_email_checkbox_disabled() and render_match_by_email(). Done means the checkbox is disabled when the email option is hardcoded and the existing wp-cli check remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.