Automattic / Automattic/isolated-block-editor

Unscoped WP component styles

Open
#23 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
CSS
Stars
409
Forks
66
PR merge metrics
No merged PRs in 30d

Description

We are starting to use `@wordpress/components` for our UI elements, and noticed that some unscoped styles on the raw component classes are leaking from isolated-editor.

Here are the three places I found in a quick sweep:

https://github.com/Automattic/isolated-block-editor/blob/b35819afabe88ee7ec0f741895a016147e750fe8/src/style.scss#L13
https://github.com/Automattic/isolated-block-editor/blob/b35819afabe88ee7ec0f741895a016147e750fe8/src/style.scss#L76
https://github.com/Automattic/isolated-block-editor/blob/b35819afabe88ee7ec0f741895a016147e750fe8/src/browser/style.scss#L22-L24

(We are currently only affected by the Modal ones, but just noting the Drop Zone one as well.)

Would it be possible to scope these styles to iso-editor specific nodes?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the selectors at the referenced lines in src/style.scss and src/browser/style.scss, focusing on the Modal styles and also reviewing the Drop Zone rule. Scope the affected styles to isolated-editor-specific nodes, then verify that @wordpress/components styles no longer leak outside the isolated editor.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, wordpress
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.